Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new configuration to indefinitely lock the user util admin unlock #6997

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add new configuration to indefinitely lock the user util admin unlock #6997

wants to merge 5 commits into from

Conversation

sandushi
Copy link
Contributor

@sandushi sandushi commented Oct 16, 2024 •
edited
Loading

Purpose

  • Support the feature of indefinitely lock the user account until the admin unlocks the account when initial lock duration to 0.
  • This changes support this feature with a better UX, other that set the initial lock duration to 0.
  • With the new console UI, value 0 is not allowed as the initial lock duration
  • So, with these changes , introduced a new option called Enable indefinite user lock duration check box to enable this feature.
  • When enable this option, the account lock duration is not needed and the input field is disabled.

When disabling the feature

Screenshot from 2024-10-16 09-06-47

When enabling the feature

Screenshot from 2024-10-16 09-07-04

Related Issues

wso2/product-is#21219

Related PRs

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@codecov Codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.79%. Comparing base (90b52b9) to head (13ccd20).
Report is 28 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6997   +/-   ##
=======================================
  Coverage   31.79%   31.79%           
=======================================
  Files          41       41           
  Lines         890      890           
  Branches      204      204           
=======================================
  Hits          283      283           
  Misses        607      607
Flag Coverage Δ
@wso2is/core 31.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@DilshanSenarath
Copy link
Contributor

Don't we need to disable the Account lock duration increment factor as well?

@sandushi sandushi mentioned this pull request Oct 16, 2024
Merged
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@sandushi sandushi mentioned this pull request Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DilshanSenarath DilshanSenarath DilshanSenarath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandushi @DilshanSenarath @wso2-jenkins-bot